Let pre-commit fix formatting issue in master #498
Merged
+20
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…to aki/pre-commit
akihironitta
changed the title
Borda
reviewed
Feb 10, 2025
Comment on lines
+56
to
+61
| .github/workflows/changelog.yml | ||
| .github/workflows/dependabot-auto-merge.yml | ||
| .github/workflows/documentation.yml | ||
| .github/workflows/labeler.yml | ||
| .github/workflows/linting.yml | ||
| .github/workflows/release.yml |
There was a problem hiding this comment.
why ignore these since you have then with linter?
pytorch-frame/.pre-commit-config.yaml
Line 32 in 652b573
There was a problem hiding this comment.
Hi Jirka! What do you mean? I think unit tests should be triggered based on changes in the codebase (and/or other things like pyproject.toml), but we don't need to run unit tests based on any changes in linting.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.